Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: oneOf should not be allowed in message components #345

Merged
merged 3 commits into from
Mar 14, 2023
Merged

fix: oneOf should not be allowed in message components #345

merged 3 commits into from
Mar 14, 2023

Conversation

jonaslagoni
Copy link
Member

Description
This PR fixes that it currently possible to define messages with oneOf in components when the spec clearly doesn't allow it.

Currently allowed, but should not:

components:
  messages:
    UserSignedUp:
      oneOf:
        - payload:
            type: object
            properties:
              displayName:
                type: string
                description: Name of the user
              email:
                type: string
                format: email
                description: Email of the user

Related issue(s)
Fixes #335

@jonaslagoni
Copy link
Member Author

Thanks @dalelane 👍

@jonaslagoni
Copy link
Member Author

/rtm

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@asyncapi-bot asyncapi-bot merged commit dfd288f into asyncapi:next-major-spec Mar 14, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0-next-major-spec.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalelane dalelane dalelane approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@smoya smoya Awaiting requested review from smoya smoya is a code owner

@char0n char0n Awaiting requested review from char0n char0n is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonaslagoni @asyncapi-bot @dalelane